Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): SimpleOrientationSensor Sample Crash #1179

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): closes unoplatform/uno#17688

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Gallery iOS Application crashes when using the SimpleOrientationSensor sample page

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam requested a review from kazo0 November 22, 2024 05:56
@ajpinedam ajpinedam self-assigned this Nov 22, 2024
@ajpinedam ajpinedam changed the title fix(iOS): Simpleorientation Sample Crash fix(iOS): SimpleOrientationSensor Sample Crash Nov 22, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1179.eastus2.3.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1179.eastus2.3.azurestaticapps.net

Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When viewing change without whitespace the fix is easier to see. However, please check if the new formatting adheres to the rest of the project

@ajpinedam ajpinedam force-pushed the fix/ios.simpleorientation.crash branch from 3323156 to 44069a4 Compare November 26, 2024 04:48
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1179.eastus2.3.azurestaticapps.net

@unodevops
Copy link

⚠️⚠️ The build 148446 has failed on Uno.Gallery - CI.

@jeromelaban jeromelaban merged commit 86ace90 into master Nov 27, 2024
14 of 18 checks passed
@jeromelaban jeromelaban deleted the fix/ios.simpleorientation.crash branch November 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gallery][iOS][Non-UI features] Simple Orientation - App crashes while Face-down
6 participants